PR 259969 259969 - The automotive letter on the Y axis of the dimensions alwa

huangyhg

259969 - The automotive letter on the Y axis of the dimensions always stays on O independent from the direction of the deviation.
<< Werner Habermann  --  02/21/09  11:20:29>>
The automotive letter on the Y axis of the dimensions always stays on O independent from the direction of the deviation.
I noticed this during the verification of 259717. I verified that this is broken in 423, 432 and 44.
It's working well in 37MR4 (see AVI clip)
Steps to duplicate:
Create a dimension with a MEAS value of 0 in Y (or open the attached pp)
Change the NOMINAL value to 1 and to -1
(see AVI)
Result:
The automotive letter is O in both cases
Expected result:
I for -1
O for 1
Please get this working again before FORD or VOLVO notice this.

<<END>>


<< Werner Habermann  --  03/13/09  09:29:00>>
Don, this is right. I verified that this is work well. Thanks.
<<END>>
<< Changes made by Werner Habermann -- 03/13/09  09:29:04>>
Status:  RESOLVED to CLOSED
<<END>>
<< David Petrizze  --  03/03/09  08:13:30>>
Reviewed.
<<END>>
<< Changes made by David Petrizze -- 03/03/09  08:13:33>>
Action:  David Petrizze to Werner Habermann, Status:  REVIEW to RESOLVED
<<END>>
<< Don Turcotte  --  03/03/09  08:49:18>>
Werner,
The definition of I (Inner) is when the deviation from nominal to measured is in the direction of the origin.  The definition of O (outer) is when the deviation from nominal to measured is away from the origin.  In this test program, the MEAS value is at 0 (the origin) so whether you set the nominal to 1 or -1, the deviaiton from nominal to measured is in the direction of the origin, therefore always I.  You should create a test case where the MEAS is, for example, 0.5 and try nominals of 0.4 and 0.6.  Also try with a negative MEAS of,for example, -0.5 and nominals of -0.4 and -0.6.  You will see that this is working correctly.
<<END>>
<< Changes made by Don Turcotte -- 03/03/09  08:49:57>>
Action:  Don Turcotte to David Petrizze, Status:  OPEN to REVIEW
<<END>>
<< Changes made by Don Turcotte -- 03/03/09  08:49:18>>
Action:  Steve Barber to Don Turcotte
<<END>>
<< Werner Habermann  --  02/28/09  18:41:53>>
Hi Steve, I watched my verification AVI again (inside of 259969_Verification_432Feb27_090228.7z) and noticed that this problem is not yet fully resolved. Sorry but I have to open the report again therefore. Yes, I can toggle from O to I but No, I can't toggle from I to O. You can see this at 1:25 and at 1:34 or you can try this with the sample pp on your own.
<<END>>
<< Changes made by Werner Habermann -- 02/28/09  18:42:03>>
Action:  David Petrizze to Steve Barber, Status:  REVIEW to OPEN
<<END>>
<< Werner Habermann  --  02/28/09  11:02:32>>
Verified in 432Feb27. From a user point of view this is fixed. Attached is archive 259969_Verification_432Feb27_090228.7z with an AVI clip of my verification sequence. Thanks Steve!!
<<END>>
<< Steve Barber  --  02/26/09  17:34:59>>
I looked at the change & talked to Don. He explained some things for me so I could understand better.
Seems OK to me.
<<END>>
<< Changes made by Steve Barber -- 02/26/09  17:35:19>>
Action:  Steve Barber to David Petrizze, Assigned:  Steve Barber to Don Turcotte
<<END>>
<< Don Turcotte  --  02/26/09  15:58:10>>
Merged into V432.
Files inserted to server
------------------------
V432\DIMENS\LOCATION.CPP

<<END>>
<< Changes made by Don Turcotte -- 02/26/09  16:00:37>>
Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  02/26/09  14:57:54>>
The basic problem here is that the routine that formats the output is using the feature nominal and not the dimension nominal.  The difference between the behavior of the single arm program and the dual arm program has nothing to do with the number of arms.  In the single arm program, the feature nominal for Y is -1 so changing the dimension nominal in this program affects only the sign of the deviation.  The determination of I or O was done using the feature nominal.  In the dual arm program, the feature nominal for Y is 0.  When the nominal is 0, the deviation letter is always O.  When the nominal is not 0, the deviation letter depends on the sign of the deviation.
I have fixed this so that m_deviation_position will be updated with the user entered nominal value, thereby ensuring that the reporting routine is using the dimension nominal and not the feature nominal.
I take issue with Werner's expected results.  The design intent for I and O is as follows:
"Deviations pointing towards the origin in the Y axis are IN (report I), and deviations pointing away from the origin are OUT (report O).  But that only applies to the Y axis."
So in the case where the MEAS value is 0, whether you enter a nominal of +1 or -1, the deviation is toward the origin and therfore reported as I.  If you create an example where the MEAS is non-zero and try non-zero nominal values on either size of the MEAS, you will now get the correct I or O report.
Files inserted to server
------------------------
V44B\DIMENS\LOCATION.CPP
<<END>>
<< Steve Barber  --  02/25/09  18:56:33>>
Uploaded:
V432\DIMENS\END_LOCA.CPP
V432\DIMENS\LOCATION.CPP
V432\DIMENS\TP_END_L.CPP
V432\MENU\DIMENSIO.CPP
V44B\DIMENS\END_LOCA.CPP
V44B\DIMENS\LOCATION.CPP
V44B\DIMENS\TP_END_L.CPP
V44B\MENU\DIMENSIO.CPP
To have 1 method to generate the letters. However, it is still wrong. While it works with the simple Test_37.PRG program, it is only because the m_deviation_position variable comes in at 0,-1,0. The multi arm one comes in with 0,0,0. Not exactly sure what needs to be done but all the letters at this point should match what v37 produces. Having 1 location also means reporting will always match the edit window.
I will need to talk to Don T. tomorrow.
<<END>>
<< Steve Barber  --  02/25/09  18:02:16>>
This is failing due to the multiple arms for some reason. I saved the part program back to a V37 one and it did the same thing.
m_deviation_position is not being generated correctly for multi arms.
<<END>>
<< Steve Barber  --  02/25/09  07:45:32>>
I can look into this.
<<END>>
<< Changes made by Steve Barber -- 02/25/09  07:45:41>>
Action:  Reporting Group to Steve Barber, Assigned:  Reporting Group to Steve Barber
<<END>>
<< Changes made by Tim Wernicke -- 02/23/09  11:05:31>>
Priority:  to Stop Rel.
<<END>>
<< Werner Habermann  --  02/23/09  14:55:26>>
Sorry but I packed the wrong AVI clip to archive 259969_Verification432Feb20_090223.7z. 259969_Verification_432Feb20_090223_CorrectAVIClip.7z contains the right clip now. It shows that the edit window does wrong. The values for O do not change with the deviation.
Expected result:
I for -1
O for 1
<<END>>
<< Changes made by Werner Habermann -- 02/23/09  14:55:53>>
Status:  MOREINFO to OPEN
<<END>>
<< Changes made by Werner Habermann -- 02/23/09  14:55:46>>
Action:  Werner Habermann to Reporting Group
<<END>>
<< Steve Barber  --  02/23/09  08:46:54>>
The videos are still showing TEST_42.PRG. It is unclear to me which area is wrong - the edit window or the report?
Changing the value to -1/1 displays "I" or "O" in V37 in the edit window. Performing the same thing in V44 "O" is displayed in both cases.
I guess I need specific information on what is correct and what is not.
V37 had only the edit window. V4x has the edit window & reporting.
<<END>>
<< Changes made by Steve Barber -- 02/23/09  08:47:01>>
Action:  Reporting Group to Werner Habermann, Status:  OPEN to MOREINFO
<<END>>
<< Werner Habermann  --  02/23/09  12:33:11>>
I added 259969_Verification432Feb20_090223.7z with the correct part program, the probe file and another AVI clip.
<<END>>
<< Changes made by Werner Habermann -- 02/23/09  12:33:37>>
Action:  Werner Habermann to Reporting Group
<<END>>
<< Steve Barber  --  02/22/09  16:09:12>>
Using the attached part program seems to be correct (Test_37.PRG). The AVI indicating V4x is wrong is not using this part program.
I can switch between -1 & 1 for the Y value & it toggles between O & I. This matches what the edit window is displaying.
Perhaps it has something to do with the multiple arms? Probe file as well as the part program being used in V4x should be supplied.
<<END>>
<< Changes made by Steve Barber -- 02/22/09  16:09:17>>
Action:  Reporting Group to Werner Habermann
<<END>>