PR 259459 V44 Dimension/GDT Tests: I get an error message when I try to as

huangyhg

V44 Dimension/GDT Tests:    I get an error message when I try to assign more than 2 characters to a datum name.
<< Don Ruggieri  --  02/02/09  18:45:19>>
data is in 02022009_03a.zip.  I get an error message when I try to assign more than 2 characters to a datum name.
Steps to reproduce:
I n the dimensioning section of the test plan, there are instructions to verify that custom datum names can be assigned.
I proceed to assign a datum name to a feature, and enter the character string ABCDEFG and then press the Create button.
I get an error message indicating that I am supposed to "Enter no more than 2 characters."
Yet, when I acknowledge the message, it assigns the entire character string to the datun name, 7 characters in all.
Which is correct?
<<END>>


<< Don Turcotte  --  03/24/09  16:47:08>>
There is still a problem.  If select a feature on the DATDEF dialog, then enter a Datum that is more than 2 characters, then Create, I get the error dialog "Enter no more than 2 characters".  If I try to correct the Datum name to be only 2 characters, the "Create" button is now grayed out.  I have to select a different feature, then reselect the feature that I wanted to get the "Create" button to become active again.  If I do this, the datum name is no longer converted to upper case when the Create button is clicked to create the DATDEF.
<<END>>
<< Changes made by Don Turcotte -- 03/24/09  16:47:22>>
Action:  Don Turcotte to Yanhua Huang
<<END>>
<< Yanhua Huang  --  03/24/09  21:57:49>>
Fixed #2.
******************************
Tue Mar 24 21:57:11 2009
******************************
Files inserted to server
------------------------
V44B\INCLUDE\DATDEFDLG.H
V44B\MENU\DATDEFDLG.CPP
<<END>>
<< Changes made by Yanhua Huang -- 03/24/09  21:58:03>>
Action:  Yanhua Huang to Don Turcotte, Status:  OPEN to REVIEW
<<END>>
<< Yanhua Huang  --  03/24/09  21:56:37>>
2. I keep getting the message "Enter no moer than 2 characters" even though I am no longer trying to create a DATDEF but just trying to exit the dialog.
<<END>>
<< Don Turcotte  --  03/23/09  12:59:58>>
Reviewed.
The problem here is that if I try to create a DATDEF with more than 2 characters and click "Create", I get the message dialog "Enter no more than 2 characters" which is ok.  But when I try to Close the dialog, I cannot.   I keep getting the message "Enter no moer than 2 characters" even though I am no longer trying to create a DATDEF but just trying to exit the dialog.
<<END>>
<< Changes made by Don Turcotte -- 03/23/09  13:00:11>>
Action:  David Petrizze to Yanhua Huang, Status:  REVIEW to OPEN
<<END>>
<< Changes made by Don Turcotte -- 03/23/09  12:59:58>>
Action:  Don Turcotte to David Petrizze
<<END>>
<< Yanhua Huang  --  03/23/09  23:48:42>>
The essential reason here is that never walk into OnKillfocusEditDatum when datum name is losting focus.
<<END>>
<< Yanhua Huang  --  03/22/09  23:47:58>>
Fixed in V44B.
******************************
Sun Mar 22 23:46:31 2009
******************************
Files inserted to server
------------------------
V44B\INCLUDE\DATDEFDLG.H
V44B\MENU\DATDEFDLG.CPP
<<END>>
<< Changes made by Yanhua Huang -- 03/22/09  23:48:31>>
Action:  Yanhua Huang to Don Turcotte, Status:  OPEN to REVIEW
<<END>>
<< Yanhua Huang  --  03/22/09  23:47:29>>
1.1 The problem here is that could not walk into OnKillfocusEditDatum function.
Change to ON_CBN_KILLFOCUS, since change edit box to combobox for datum name.
   
<<END>>
<< Yanhua Huang  --  02/23/09  22:59:55>>
2. Datum letters (lower case) in datum creation dialog should be case insensitive (should be automatically converted to upper case).
The rule in datum creation dialog should be same as edit window.
[10:51:16 PM] Donald Turcotte says: Yes, datum letters should be case insenstive (should be automatically converted to upper case).
<<END>>
<< Yanhua Huang  --  02/23/09  22:57:34>>
1. limit datum name <= 2 characters ( >= 1) in datum creation dialog.
[9:34:12 PM] Donald Turcotte says: It's an issue if having a datum of more than 2 characters causes actual problems either in the display of the FCF callout in the graphics window or in the report.
<<END>>
<< Changes made by Tim Wernicke -- 02/03/09  09:49:22>>
Category:  dimensions to GD&T, Action:  Don Turcotte to Yanhua Huang, Assigned:  Don Turcotte to Yanhua Huang, Priority:  to Medium
<<END>>

huangyhg

IMPLEMENT_DYNCREATE(CDATDEFComboBox, CComboBox)

BEGIN_MESSAGE_MAP(CDATDEFComboBox, CComboBox)
  ON_WM_CHAR()
END_MESSAGE_MAP()

void CDATDEFComboBox::OnChar(UINT nChar, UINT nRepCnt, UINT nFlags)
{
  if(_istalpha((wint_t)nChar))
  {
    CComboBox::OnChar(nChar, nRepCnt, nFlags);
  }
  else if(nChar == VK_BACK)
    CComboBox::OnChar(nChar, nRepCnt, nFlags);
}



class CDATDEFComboBox: public CComboBox
{
public:
  afx_msg void OnChar(UINT nChar, UINT nRepCnt, UINT nFlags);
protected:
  DECLARE_MESSAGE_MAP()
  DECLARE_DYNCREATE(CDATDEFComboBox)
};



  afx_msg void OnChar(UINT nChar, UINT nRepCnt, UINT nFlags);