PR 256753 GD&TTrue position diameter tolerance graphic not displaying

huangyhg

GD&TTrue position diameter tolerance graphic not displaying correct deviation
<< Phil Leather  --  08/27/08  16:57:50>>
A customer has reported a problem with the graphic for the deviation of a circle in the new GDT dimensioning as displaying incorrectly.
I have tested this and also agree, i have also tested in V4.3 and get the same results.
Steps to reproduce:
If i measure a circle and dimension Location the Diameter of the circle, with a +0.2  and - 0.0 tolerance, the deviation is correct and the graphic also appears to be correct.
If i then do True Position and give the circle the +0.2  and - 0.0 tolerance the graphic for deviation is not correct,
If i do the same in legacy true position the graphic is fine.
I will attach a program and also a Power point from the customer, this shows what we are seeing.
Note the actual deviation appears correct but the graphic is wrong.
<<END>>


<< Changes made by Neil Kay -- 02/25/09  19:19:21>>
Action:  David Petrizze to Phil Leather, Status:  REVIEW to RESOLVED
<<END>>
<< Don Turcotte  --  01/06/09  08:29:00>>
Reviewed.
OK
<<END>>
<< Changes made by Don Turcotte -- 01/06/09  08:29:00>>
Action:  Don Turcotte to David Petrizze
<<END>>
<< Yanhua Huang  --  12/11/08  23:56:06>>
I also get a crash when try to display any report today., V44B is now building successfully for me in VS 2008.
<<END>>
<< Don Turcotte  --  12/09/08  14:25:40>>
I tried to review this but with V44B debug build using VS2008, the ap crashes whenever I try to display the report.  I sent out e-mail:
"I have built latest V44B (rebuild all) in debug config using VS2008.  I can load/create programs, but when I try to display the report I get a crash with the following call stack (occurs with any program):

            ntdll.dll!7c90120e()         
            [Frames below may be incorrect and/or missing, no symbols loaded for ntdll.dll]     
            ntdll.dll!7c96c201()         
            ntdll.dll!7c96c63e()         
            ntdll.dll!7c9603b0()         
>          msvcr80d.dll!_free_dbg_nolock(void * pUserData=0x1b938840, int nBlockUse=1)  Line 1279 + 0x9 bytes      C++
            msvcr80d.dll!_free_dbg(void * pUserData=0x1b938840, int nBlockUse=1)  Line 1220 + 0xd bytes      C++
            msvcr80d.dll!operator delete(void * pUserData=0x1b938840)  Line 54 + 0x10 bytes  C++
            CXIMAGECRTD.DLL!071b1f6d()   
            PCDLRN.exe!TextReportingObject::AddLabel(const ATL::CStringT<wchar_t,StrTraitMFC_DLL<wchar_t,ATL::ChTraitsCRT<wchar_t> > > & label="FILE_HEADER.LBL", CReportingData * data=0x0012e348)  Line 1294 + 0x34 bytes       C++

This seems to be related to trying to delete images (CXIMAGECRTD.DLL).

"
<<END>>
<< Yanhua Huang  --  12/04/08  22:08:32>>
Fixed in V44B.
The FCF "Size" table graphic should report the same way as the Location dimension D axis and the legacy true position DF axis.
Changed code below.
// if both ptol and mtol are on the same side of nominal (both positive or both negative), then this is not bilateral.
  double dbMinusTol = -mtol;
  if ((ptol >= 0 && dbMinusTol >= 0) || ptol <= 0 && dbMinusTol <= 0)
    m_line1_isbilateral.Add(FALSE);
  else
    m_line1_isbilateral.Add(TRUE);  
// m_line1_devpercent_nom specifies where the nom value is in this case since it is not necessarily in the middle.
  m_line1_devpercent_nom.Add((- dbMinusTol)/(ptol - dbMinusTol) * 100);  
******************************
Thu Dec 04 22:02:56 2008
******************************
Files inserted to server
------------------------
V44B\DIMENS\FEATCTRLFRM.CPP
<<END>>
<< Changes made by Yanhua Huang -- 12/04/08  22:08:47>>
Action:  Yanhua Huang to Don Turcotte, Status:  OPEN to REVIEW
<<END>>
<< Changes made by Tim Wernicke -- 08/27/08  11:46:12>>
Category:  dimensions to GD&T, Action:  Tim Wernicke to Yanhua Huang, Assigned:   to Yanhua Huang, Priority:  to Critical
<<END>>