PR 257416 Using 0.0/0.1 tolerance for profile and location linear graphic dra

huangyhg

Using 0.0/0.1 tolerance for profile and location linear graphic draws incorrectly.
<< Rick Haduch  --  10/02/08  14:48:18>>
See the attached program and profile result. Shows incorrect MEAS and DEV for the given tolerance of 0.0/0.01. Program created in v3.2, opened in v4.3 MR1.
<<END>>


<< Changes made by Yanhua Huang -- 03/28/09  11:15:41>>
Action:  CMM Group to Yanhua Huang
<<END>>
<< Don Turcotte  --  10/06/08  16:01:04>>
I have resolved the issue of the linear graphic not drawing correctly when either the +tol or -tol is 0.0 for a bilateral tolerance.
Fixed in V43B, V44B.
Files inserted to server
------------------------
V43B\DIMENSIONREPORTCONTROLS\DimLinearControl.CPP
V43B\NETDLL\DimensionReportControls.ocx
V43B\NETDLL\DimensionReportControls.pdb
V43B\NETDLL\DimensionReportControlsd.ocx
V44B\DIMENSIONREPORTCONTROLS\DimLinearControl.CPP
V44B\NETDLL\DimensionReportControls.ocx
V44B\NETDLL\DimensionReportControls.pdb
V44B\NETDLL\DimensionReportControlsd.ocx
<<END>>
<< Changes made by Don Turcotte -- 10/06/08  16:01:34>>
Action:  Don Turcotte to CMM Group, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  10/03/08  16:51:29>>
The profile analysis is working as designed.  The customer needs to look at the MAX/MIN values when using formandlocation as dictated by the Y14.5 standard.
I am looking into the issue with the linear graphic which is not displaying correctly.
<<END>>
<< Don Turcotte  --  10/02/08  17:10:20>>
Rick sent me his modified program.  The MEAS value reports MAX-MIN for formandlocation.  This value is less than the -tol (+tol is 0.0), but the profile is reported as out of tol because the max value is greater than 0.0.  His expectation is that since the MEAS value is less than the -tol, this should be in tolerance.  I believe PC-DMIS correctly reports this as out of tol because the max value in this formandlocation profile exceeds the +tol limit of 0.0.
A secondary issue is that for this out of tol report, the graphic is shown in green without an out-of-tol arrow.
<<END>>
<< Don Turcotte  --  10/02/08  16:46:25>>
I could not duplicate the program when I loaded this program in the latest V431.  I talked with Rick about this and he is going to look at this again.  He may be using an older version of V43 MR1.
<<END>>
<< Changes made by Tim Wernicke -- 10/02/08  14:20:55>>
Action:  Tim Wernicke to Don Turcotte, Assigned:   to Don Turcotte, Priority:  to Critical
<<END>>

huangyhg

void CDimLinearControl:raw(double deviation, int numzones,float multipletolzone,BOOL showcolorsintwodirections,OLE_COLOR * colors,
// PR257416
if( nominal == 100.0 )
{
if( deviation <= nominal && deviation2 > nominal )
{
// readjust the deviations and nominal so the out-of-tol positive is drawn correctly
nominal = (nominal / 110.0) * 100.0;
deviation = (deviation / 110.0) * 100.0;
}
}
else if( nominal == 0.0 )
{
if( deviation < nominal && deviation2 >= nominal )
{
// readjust the deviations and nominal so the out-of-tol negative is drawn correctly
nominal = (10.0 / 110.0) * 100.0;
deviation2 = (deviation2 / 110.0) * 100.0;
}
}