PR 258262 graphics window shows old form analysis

huangyhg

graphics window shows old form analysis
<< Chuck Burbank  --  11/14/08  19:36:37>>
I  believe this is a problem in all versions. I remember seeing it long ago, but it's one of those things where you think you're seeing things.  You run the same data again and then all is well.
<<END>>
<< Chuck Burbank  --  11/14/08  19:34:20>>
At least in Offline, the graphical display of form errors is delayed. If you make a run, the graphcal display of the form errors is actually the previous run. This is a problem for CNC as we use offline execution to bring our data in  So when a customer is looking at the graphics (or when we are trying to debug things like calibration), the data in the graphics window is actually old.
Steps to reproduce:
Generate some real data some how.  create a dimension with form that is displayed graphically.  See that it shows non zero form errors.  Now run the program offline.  
Results:
The form is zero in the edit window and in the report window as you would expect.  but it is not zero in the graphics window.
Expected Results:
expect zero (or the true values) in all windows.
<<END>>

<< Changes made by Yanhua Huang -- 03/28/09  11:16:15>>
Action:  CMM Group to Yanhua Huang
<<END>>
<< Don Turcotte  --  11/19/08  16:01:36>>
The issue here is that the old graphical analysis was not being erased before the new was drawn.  When you run offline, all the deviations are 0.  So there are no deviation arrows to draw and it is not obvious what has happened.
Also fixed a problem with toggling the GRAPH= parameter in the edit window to OFF (graphical analysis not erased) and fixed update problem with textual analysis in the report.
Attached my test program.
Fixed in V43B, V44B for all form types.
Files inserted to server
------------------------
V43B\DIMENS\DIM_2D_A.CPP
V43B\DIMENS\DIM_2D_D.CPP
V43B\DIMENS\DIM_3D_A.CPP
V43B\DIMENS\DIM_3D_D.CPP
V43B\DIMENS\DIM_ANGU.CPP
V43B\DIMENS\DIM_CIRC.CPP
V43B\DIMENS\DIM_COAX.CPP
V43B\DIMENS\DIM_CONC.CPP
V43B\DIMENS\DIM_CYLY.CPP
V43B\DIMENS\DIM_FLAT.CPP
V43B\DIMENS\DIM_PARA.CPP
V43B\DIMENS\DIM_PERP.CPP
V43B\DIMENS\DIM_PROF.CPP
V43B\DIMENS\DIM_RUNO.CPP
V43B\DIMENS\DIM_STRA.CPP
V43B\DIMENS\DIM_SYMM.CPP
V43B\DIMENS\FLATNESS_LOCATION.CPP
V43B\DIMENS\ROUNDNESS_LOCATION.CPP
V43B\DIMENS\START_LO.CPP
V43B\DIMENS\STRAIGHTNESS_LOCATION.CPP
V43B\DIMENS\TP_START.CPP
V43B\INCLUDE\TP_FLATNESS_LOCATION.H
V43B\INCLUDE\TP_ROUNDNESS_LOCATION.H
V43B\INCLUDE\TP_STRAIGHTNESS_LOCATION.H
V44B\DIMENS\DIM_2D_A.CPP
V44B\DIMENS\DIM_2D_D.CPP
V44B\DIMENS\DIM_3D_A.CPP
V44B\DIMENS\DIM_3D_D.CPP
V44B\DIMENS\DIM_ANGU.CPP
V44B\DIMENS\DIM_CIRC.CPP
V44B\DIMENS\DIM_COAX.CPP
V44B\DIMENS\DIM_CONC.CPP
V44B\DIMENS\DIM_CYLY.CPP
V44B\DIMENS\DIM_FLAT.CPP
V44B\DIMENS\DIM_PARA.CPP
V44B\DIMENS\DIM_PERP.CPP
V44B\DIMENS\DIM_PROF.CPP
V44B\DIMENS\DIM_RUNO.CPP
V44B\DIMENS\DIM_STRA.CPP
V44B\DIMENS\DIM_SYMM.CPP
V44B\DIMENS\FLATNESS_LOCATION.CPP
V44B\DIMENS\ROUNDNESS_LOCATION.CPP
V44B\DIMENS\START_LO.CPP
V44B\DIMENS\STRAIGHTNESS_LOCATION.CPP
V44B\DIMENS\TP_START.CPP
V44B\INCLUDE\TP_FLATNESS_LOCATION.H
V44B\INCLUDE\TP_ROUNDNESS_LOCATION.H
V44B\INCLUDE\TP_STRAIGHTNESS_LOCATION.H
<<END>>
<< Changes made by Don Turcotte -- 11/19/08  16:02:36>>
Action:  Don Turcotte to CMM Group, Status:  OPEN to REVIEW
<<END>>
<< Bill Velle  --  11/17/08  10:12:37>>
Hi Don,
This is not a graphics issue.  Graphics is only displaying what it is told to display.
Based on Tim's and Chuck's comments, I did an auto assign for 'dimensions'.
If it is not you, then please reassign to Tim so that it can be assigned to the correct people/group.
- BV
<<END>>
<< Changes made by Bill Velle -- 11/17/08  10:12:39>>
Category:  graphics to dimensions, Action:  Bill Velle to Don Turcotte, Assigned:  Bill Velle to Don Turcotte
<<END>>
<< Tim Wernicke  --  11/17/08  08:05:43>>
Bill, what do you think here?  Is this a graphics problem or something within the Scan or Dim command?
<<END>>
<< Changes made by Tim Wernicke -- 11/17/08  08:05:44>>
Action:  Tim Wernicke to Bill Velle, Assigned:  Tim Wernicke to Bill Velle, Priority:  to Critical
<<END>>
<< Chuck Burbank  --  11/14/08  19:56:15>>
not sure who this should go to,
<<END>>
<< Changes made by Chuck Burbank -- 11/14/08  19:56:16>>
Action:  Bill Velle to Tim Wernicke, Assigned:  Bill Velle to Tim Wernicke
<<END>>

huangyhg

if( send_to_display ) // PR258262
    remove_graphical_analysis();

huangyhg

BOOL CPCDroundness_location::do_math(int theo_or_meas, int search)
  // PR258262 - now that we have done the math, fill the textual analysis arrays if requested
  if( start_ptr && ((CPCDstart_location *)start_ptr)->get_text_anal_options() != ANALYSIS_OFF )
    textual_analysis(FALSE);

huangyhg

CPCDcommand * CPCDstart_location::read_text(CString text,
D_TYPES:_TYPE dtype,
long typeindex)
{
BYTE edit_code = (BYTE)_ttoi(text);
CPCDcommand * ptr;
CPCDcommand * temp_cmd;

// If anything was changed except for the textual_analysis ON/OFF toggle,
// remove the current graphical analysis so it can be redrawn when
// the text is created again.
if (m_graph_anal_options >= ANALYSIS_ON && dtype != D_TYPES::TEXT_ANALYSIS &&
dtype != D_TYPES::OUTPUT_TYPE)
{
// PR258262 - find the form axis CPCDcommand *
CPCDcommand * pFormDim = NULL;
CPCDcommand * p = this->next;
while(p && !p->is_dim_end_location())
{
switch(p->type())
{
case DIMENSION_ROUNDNESS_LOCATION:
pFormDim = ((CPCDroundness_location *)p)->m_dim_round;
break;
case DIMENSION_FLATNESS_LOCATION:
pFormDim = ((CPCDflatness_location *)p)->m_dim_flat;
break;
case DIMENSION_STRAIGHTNESS_LOCATION:
pFormDim = ((CPCDstraightness_location *)p)->m_dim_straight;
break;
default:
break;
}
if( pFormDim )
{
remove_gh_from_list(GARROWS, pFormDim);
remove_gh_from_list_AppData(GARROWS,(DWORD)pFormDim);
break;
}

p = p->next;
}
}