几何尺寸与公差论坛

 找回密码
 注册
查看: 444|回复: 1

PR 256774 Profile dimensions don't update their text when editing Reference

[复制链接]
发表于 2009-4-1 20:29:36 | 显示全部楼层 |阅读模式
Profile dimensions don't update their text when editing Reference ID in summary mode
<< Wade Burton  --  08/28/08  11:12:51>>
This was found when running the automated test EditWindowVerifyDataSummaryMode.
Use the attached part program, in summary mode go to PROF1, open up the Settings folder, edit the Reference ID, changing it from SCN7 to SCN5, and tab off the field, as the automated test would do.  If you type it in lower-case, you can see that "scn5" doesn't get updated to "SCN5" in the Reference ID field, so it seems that it isn't accepted.  The text of the dimension is not updated in the title of the dimension, which makes the automated test not be able to attach to that text anymore, because it is expecting the text to be "ROF1 = Dimension Profile of Line : SCN5", with the updated ID.  
If I switch to command mode, the dimension appears to have SCN5, and not SCN7, so it appears the dimension is accepting the Reference ID, but just not updating it in the summary mode.  The other dimensions and features don't behave this way.  Somehow, profile dimension is preventing the updating of the text.
<<END>>


<< Changes made by Yanhua Huang -- 03/28/09  11:15:10>>
Action:  CMM Group to Yanhua Huang
<<END>>
<< Don Turcotte  --  09/16/08  08:54:46>>
I have uploaded the fix to CEditWin:ositionCursorAtDtype(...)  to correct the reported problem.  
I also found a problem when trying to add a feature to the true position FCFLOC1 in the summary mode edit window.  I have fixed this in CPCDFeatCtrlFrm::ConvertAxesLists(...).
Files inserted to server
------------------------
V44B\DIMENS\FEATCTRLFRM.CPP
V44B\EDITORS\EDITWIN.CPP
<<END>>
<< Changes made by Don Turcotte -- 09/16/08  08:55:19>>
Action:  Don Turcotte to CMM Group, Status:  OPEN to REVIEW
<<END>>
<< Don Turcotte  --  09/15/08  17:11:32>>
I have a solution to this in CEditWin:ositionCursorAtDtype(...) but need to do more tests to make sure this has no side effects.
<<END>>
<< Don Turcotte  --  09/11/08  17:13:15>>
The problem here is that when CEditorTreeView::UpdateItemEditValue(...) calls m_pPartProgram->m_editor->ositionCursorAtDtype(pCmd, dtype, typeindex), the typeindex being looked for is 0 but the typeindex in Obj[Line].typeindex[Field] for REF_ID is 1.  There seem to have been changes made to the reporting engine which introduced this confusion since I see comments about other pr's to address similar problems (#244740, # 221259) by looking for either typeindex 0 or 1 when referencing REF_ID.
<<END>>
<< Don Turcotte  --  09/10/08  17:15:58>>
This is similar to 251249 which I fixed, but the problem here seems to be different.  The code that was fixed in 251249 for CPCDdim_flatness is correct for CPCDdim_profile.  For CPCDdim_flatness, the read_text(...) method is called from the editor tree view leave_field(...) method, but for CPCDdim_profile, the read_text(...) method is called from the editor tree view UpdateItemEditValue(...) method.
<<END>>
<< Changes made by Neil Kay -- 08/29/08  09:52:25>>
Action:  Tim Wernicke to Don Turcotte, Assigned:   to Don Turcotte
<<END>>
<< Changes made by Tim Wernicke -- 08/28/08  16:39:24>>
Action:  Tim Wernicke to Yanhua Huang, Assigned:   to Yanhua Huang, Priority:  to High
<<END>>
 楼主| 发表于 2009-4-1 20:38:05 | 显示全部楼层

回复: PR 256774 Profile dimensions don't update their text when editing Refe

BOOL CEditWin:ositionCursorAtDtype(CPCDcommand *cmd, D_TYPES:_TYPE dtype, int TypeIndex)
if(Obj[Line].dtype[Field] == dtype && (Obj[Line].typeindex[Field] == TypeIndex || (TypeIndex==0 && Obj[Line].typeindex[Field]==1))) // PR256774
您需要登录后才可以回帖 登录 | 注册

本版积分规则

QQ|Archiver|小黑屋|几何尺寸与公差论坛

GMT+8, 2024-12-22 23:21 , Processed in 0.037596 second(s), 19 queries .

Powered by Discuz! X3.4 Licensed

© 2001-2023 Discuz! Team.

快速回复 返回顶部 返回列表