yang686526

odamfcapp - plotstyle bug? ctb color
odamfcapp - plotstyle bug? ctb color
odpsplotstyledata::color() returns incorrect value when ctb file is loaded by odgicontextfordbdatabase::loadplotstyletable() for these particular drawings attached.
the attached bitmap png shows the difference between acad2006 and odmfcapp.
make sure loadplotstyletable() located in dwgviewer.cpp is called when trying to reproduce the problem in odamfcapp.
i'm able to reproduce this problem in dwgdirect versions 1.12.04, 1.13.02, and the latest version 1.14.01
can anyone confirm that this is a bug and perhaps suggest immediate workaround?
thanks
codey
attached files

yes, this is a bug. thank you for bugreport. fix will be available in 1.14.02.
about imediate workaround... bug was in function odgsbasevectorizeview::effectiveplotstyle(). the bugfree edition of this function is:
code:
const odpsplotstyledata& odgsbasevectorizeview::effectiveplotstyle()
{
const odgisubentitytraitsdata& entitytraits = effectivetraits();
// plotstyles are applied only in 2d optimized mode
if(mode() == k2doptimized)
{
odgicontext:styletype pstype = usergicontext()->plotstyletype();
if(pstype == odgicontext::kpsbyname)
{
if(m_psnid!=entitytraits.plotstylenameid())
{
m_psnid = entitytraits.plotstylenameid();
usergicontext()->plotstyle(m_psnid, m_plotstyle);
}
}
else if(pstype == odgicontext::kpsbycolor)
{
if(entitytraits.truecolor().isbyaci())
{
if(m_npenindex != entitytraits.color())
{
m_npenindex = entitytraits.color();
usergicontext()->plotstyle(m_npenindex, m_plotstyle);
}
}
else
{
m_plotstyle = odpsplotstyledata();
m_npenindex = -1;
}
}
else
{
m_plotstyle = odpsplotstyledata();
m_npenindex = -1;
}
}
else
{
m_plotstyle = odpsplotstyledata();
m_npenindex = -1;
}
m_effectiveplotstyle = m_plotstyle;
odcolorref bgcol = device()->getcolor(0);
oduint8 bgred = odgetred(bgcol);
oduint8 bggreen = odgetgreen(bgcol);
oduint8 bgblue = odgetblue(bgcol);
odcmentitycolor effectivecolor;
if(m_plotstyle.color()==odcmentitycolor(0xff,0xff,0xff)) // use entity
{
if(entitytraits.truecolor().isbyaci())
effectivecolor = odtocmcolor(device()->getcolor(entitytraits.color()));
else
effectivecolor = entitytraits.truecolor();
}
else
{
effectivecolor = m_effectiveplotstyle.color();

// in some cases we should reverse colors (cr3162)
// (condition hust like in autocad)
if(effectivecolor == odcmentitycolor(bgred, bggreen, bgblue))
{
if(bgred == 0 && bggreen == 0 && bgblue == 0)
effectivecolor = odcmentitycolor(255, 255, 255);
else if(bgred == 255 && bggreen == 255 && bgblue == 255)
effectivecolor = odcmentitycolor(0, 0, 0);
}
}
// screening
int screening = m_effectiveplotstyle.screening();
if(screening < 100 && screening > 0)
{
::converttorgb(effectivecolor, device());
effectivecolor.setrgb(
(oduint8)odround((double)bgred +
((double)effectivecolor.red() - (double)bgred) * (double)screening / 100.0),
(oduint8)odround((double)bggreen +
((double)effectivecolor.green() - (double)bggreen) * (double)screening / 100.0),
(oduint8)odround((double)bgblue +
((double)effectivecolor.blue() - (double)bgblue) * (double)screening / 100.0)
);
}
else if(screening == 0)
{
effectivecolor = odtocmcolor(bgcol);
}
// grayscale
if(m_effectiveplotstyle.isgrayscaleon())
{
::converttorgb(effectivecolor, device());
oduint8 gray = (oduint8)((30 * effectivecolor.red() + 59 * effectivecolor.green() + 11 * effectivecolor.blue()) / 100);
effectivecolor.setrgb(gray, gray, gray);
}
m_effectiveplotstyle.setcolor(effectivecolor);
int nlineweight = int(m_effectiveplotstyle.lineweight());
if(nlineweight < 0) // use object
m_effectiveplotstyle.setlineweight(double(entitytraits.lineweight()) / 100.);
if(entitytraits.filltype()==kodgifillalways)
{
if(m_effectiveplotstyle.fillstyle()==odps::kfsuseobject)
m_effectiveplotstyle.setfillstyle(odps::kfssolid);
}
else
{
m_effectiveplotstyle.setfillstyle(odps::kfsuseobject);
}
return m_effectiveplotstyle;
}
you probably can implement it in your odgsbasevcetorizeview inheritant (or in your inheritant of our inheritant of odgsbasevectorizeview), and call it in your ontraitsmodified() notification.
sincerely yours,
george udov
do you have code snippets for ::converttorgb(...) used in the workaround code?
thanks,
codey

code:
inline void converttorgb(odcmentitycolor& color, odgsbasevectorizedevice* pdevice)
{
if(color.isbyaci())
color = odtocmcolor(pdevice->getcolor(color.colorindex()));
}
sincerely yours,
george udov